Skip to content

Conversation

hectorj2f
Copy link
Contributor

Summary

The attach/download SBOM commands have been declared as deprecated long time ago. I believe it is a good time to cleanup these not recommended actions.

Release Note

Remove deprecated attach/download SBOM.

@hectorj2f hectorj2f self-assigned this Sep 27, 2024
cpanato
cpanato previously approved these changes Sep 27, 2024
@cpanato cpanato requested a review from bobcallaway September 27, 2024 15:24
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.76%. Comparing base (2ef6022) to head (4fd4d2c).
Report is 219 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3891      +/-   ##
==========================================
- Coverage   40.10%   36.76%   -3.35%     
==========================================
  Files         155      202      +47     
  Lines       10044    12676    +2632     
==========================================
+ Hits         4028     4660     +632     
- Misses       5530     7435    +1905     
- Partials      486      581      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper
Copy link
Contributor

Will hold til v3

@vishal-chdhry
Copy link
Contributor

Hi @hectorj2f, @haydentherapper,
Some of us are facing a problem while downloading SBOMs using the warnings mentioned in the command. See: ko-build/ko#1346
Is there a different way to download SBOMs

@haydentherapper
Copy link
Contributor

@hectorj2f @cpanato We're about push out a major release. Do we want to clean this up now? Can you also remind me (and the other maintainers @steiza and @cmurphy) what the context was for this? It was that SBOMs weren't signed so we deprecated support for attaching them?

We can now recommend using oras to attach an SBOM or any other related artifacts as referring artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants