Repository navigation
Delete legacy verification code - #5146
Draft
aaronlew02 wants to merge 17 commits into
Draft
aaronlew02 wants to merge 17 commits into
aaronlew02 wants to merge 17 commits into
Conversation
aaronlew02
force-pushed
the
verify-delete
branch
2 times, most recently
from
October 2, 2026 21:03
7c2ca41 to
a1f43b0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5146 +/- ##
==========================================
+ Coverage 40.10% 47.08% +6.98%
==========================================
Files 155 203 +48
Lines 10044 9935 -109
==========================================
+ Hits 4028 4678 +650
+ Misses 5530 5257 -273
+ Partials 486 0 -486 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aaronlew02
force-pushed
the
verify-delete
branch
2 times, most recently
from
October 2, 2026 21:39
a3a7b63 to
c762b4f
Compare
graham87lr-creator
approved these changes
Oct 2, 2026
aaronlew02
force-pushed
the
verify-delete
branch
8 times, most recently
from
October 12, 2026 19:40
6a58658 to
ba82918
Compare
aaronlew02
force-pushed
the
verify-delete
branch
3 times, most recently
from
October 20, 2026 14:52
e029987 to
176d2c6
Compare
aaronlew02
force-pushed
the
verify-delete
branch
4 times, most recently
from
November 10, 2026 00:10
3e11c00 to
178f051
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
aaronlew02
force-pushed
the
verify-delete
branch
2 times, most recently
from
November 10, 2026 16:49
b177aa0 to
11392f7
Compare
This change fixes the interface assertion in the `attest-blob` options, which asserted `AttestOptions` instead of `AttestBlobOptions`. Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
This change removes the "new bundle generation" case and unused `newBundle` field in `TestAttestBlobCmdLocalKeyAndCert`, since the new bundle format is now the only format. Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
aaronlew02
force-pushed
the
verify-delete
branch
from
November 11, 2026 01:07
11392f7 to
099ea2f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #5145
Summary
This change removes verification logic and supporting clients obsoleted by the removal of the legacy (non-new-bundle-format) verification codepath.