Skip to content

Delete legacy verification code - #5146

Draft
aaronlew02 wants to merge 17 commits into
sigstore:mainfrom
aaronlew02:verify-delete
Draft

aaronlew02 wants to merge 17 commits into
sigstore:mainfrom
aaronlew02:verify-delete

Conversation

@aaronlew02

@aaronlew02 aaronlew02 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Depends on #5145

Summary

This change removes verification logic and supporting clients obsoleted by the removal of the legacy (non-new-bundle-format) verification codepath.

@aaronlew02
aaronlew02 force-pushed the verify-delete branch 2 times, most recently from 7c2ca41 to a1f43b0 Compare October 2, 2026 21:03
@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.89820% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.08%. Comparing base (2ef6022) to head (099ea2f).
⚠️ Report is 907 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/sign/sign.go 0.00% 12 Missing ⚠️
cmd/cosign/cli/attest.go 23.07% 10 Missing ⚠️
cmd/cosign/cli/attest/attest.go 0.00% 10 Missing ⚠️
cmd/cosign/cli/attest_blob.go 52.94% 8 Missing ⚠️
pkg/cosign/verify.go 55.55% 8 Missing ⚠️
cmd/cosign/cli/verify/verify_blob_attestation.go 81.81% 6 Missing ⚠️
cmd/cosign/cli/signcommon/common.go 0.00% 5 Missing ⚠️
cmd/cosign/cli/verify.go 50.00% 5 Missing ⚠️
cmd/cosign/cli/dockerfile.go 0.00% 3 Missing ⚠️
cmd/cosign/cli/manifest.go 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5146      +/-   ##
==========================================
+ Coverage   40.10%   47.08%   +6.98%     
==========================================
  Files         155      203      +48     
  Lines       10044     9935     -109     
==========================================
+ Hits         4028     4678     +650     
+ Misses       5530     5257     -273     
+ Partials      486        0     -486     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronlew02
aaronlew02 force-pushed the verify-delete branch 2 times, most recently from a3a7b63 to c762b4f Compare October 2, 2026 21:39
@aaronlew02
aaronlew02 force-pushed the verify-delete branch 8 times, most recently from 6a58658 to ba82918 Compare October 12, 2026 19:40
@aaronlew02
aaronlew02 force-pushed the verify-delete branch 3 times, most recently from e029987 to 176d2c6 Compare October 20, 2026 14:52
@aaronlew02
aaronlew02 force-pushed the verify-delete branch 4 times, most recently from 3e11c00 to 178f051 Compare November 10, 2026 00:10
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02
aaronlew02 force-pushed the verify-delete branch 2 times, most recently from b177aa0 to 11392f7 Compare November 10, 2026 16:49
This change fixes the interface assertion in the `attest-blob` options, which asserted `AttestOptions` instead of `AttestBlobOptions`.

Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
This change removes the "new bundle generation" case and unused `newBundle` field in `TestAttestBlobCmdLocalKeyAndCert`, since the new bundle format is now the only format.

Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants