Skip to content

Replace --use-signing-config with --no-signing-config - #5163

Draft
aaronlew02 wants to merge 18 commits into
sigstore:mainfrom
aaronlew02:no-sc
Draft

aaronlew02 wants to merge 18 commits into
sigstore:mainfrom
aaronlew02:no-sc

Conversation

@aaronlew02

Copy link
Copy Markdown
Collaborator

Summary

This change adds a new --no-signing-config flag, which forces offline signing by initializing an empty signing config.

This change also removes the deprecated --use-signing-config flag. Its functionality when set true (i.e, fetching a signing config from TUF) remains the default. Its functionality when set false is that of --no-signing-config.

Release Note

  • Added new --no-signing-config flag to force offline signing by initializing an empty signing config
  • Removed deprecated --use-signing-config flag

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.28261% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.09%. Comparing base (2ef6022) to head (7e0a8c7).
⚠️ Report is 907 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/sign/sign.go 0.00% 12 Missing ⚠️
cmd/cosign/cli/attest.go 21.42% 11 Missing ⚠️
cmd/cosign/cli/attest/attest.go 0.00% 10 Missing ⚠️
cmd/cosign/cli/attest_blob.go 50.00% 9 Missing ⚠️
pkg/cosign/verify.go 55.55% 8 Missing ⚠️
cmd/cosign/cli/verify/verify_blob_attestation.go 81.81% 6 Missing ⚠️
cmd/cosign/cli/options/attest_blob.go 0.00% 5 Missing ⚠️
cmd/cosign/cli/signcommon/common.go 28.57% 5 Missing ⚠️
cmd/cosign/cli/verify.go 50.00% 5 Missing ⚠️
cmd/cosign/cli/sign.go 33.33% 4 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5163      +/-   ##
==========================================
+ Coverage   40.10%   47.09%   +6.99%     
==========================================
  Files         155      203      +48     
  Lines       10044     9931     -113     
==========================================
+ Hits         4028     4677     +649     
+ Misses       5530     5254     -276     
+ Partials      486        0     -486     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronlew02 aaronlew02 changed the title Replace --use-signing-config with --no-signing-config Replace --use-signing-config with --no-signing-config Oct 12, 2026
@aaronlew02
aaronlew02 force-pushed the no-sc branch 2 times, most recently from 06f6f46 to 1035b65 Compare October 20, 2026 14:52
@aaronlew02
aaronlew02 force-pushed the no-sc branch 4 times, most recently from 165182d to 50a43c1 Compare November 10, 2026 00:10
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02
aaronlew02 force-pushed the no-sc branch 2 times, most recently from 46cd582 to a1e7b71 Compare November 10, 2026 16:49
This change fixes the interface assertion in the `attest-blob` options, which asserted `AttestOptions` instead of `AttestBlobOptions`.

Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
This change removes the "new bundle generation" case and unused `newBundle` field in `TestAttestBlobCmdLocalKeyAndCert`, since the new bundle format is now the only format.

Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant