Repository navigation
Replace --use-signing-config with --no-signing-config - #5163
Draft
aaronlew02 wants to merge 18 commits into
Draft
aaronlew02 wants to merge 18 commits into
aaronlew02 wants to merge 18 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5163 +/- ##
==========================================
+ Coverage 40.10% 47.09% +6.99%
==========================================
Files 155 203 +48
Lines 10044 9931 -113
==========================================
+ Hits 4028 4677 +649
+ Misses 5530 5254 -276
+ Partials 486 0 -486 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
--use-signing-config with --no-signing-config
aaronlew02
force-pushed
the
no-sc
branch
2 times, most recently
from
October 20, 2026 14:52
06f6f46 to
1035b65
Compare
aaronlew02
force-pushed
the
no-sc
branch
4 times, most recently
from
November 10, 2026 00:10
165182d to
50a43c1
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
aaronlew02
force-pushed
the
no-sc
branch
2 times, most recently
from
November 10, 2026 16:49
46cd582 to
a1e7b71
Compare
This change fixes the interface assertion in the `attest-blob` options, which asserted `AttestOptions` instead of `AttestBlobOptions`. Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
This change removes the "new bundle generation" case and unused `newBundle` field in `TestAttestBlobCmdLocalKeyAndCert`, since the new bundle format is now the only format. Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a new
--no-signing-configflag, which forces offline signing by initializing an empty signing config.This change also removes the deprecated
--use-signing-configflag. Its functionality when settrue(i.e, fetching a signing config from TUF) remains the default. Its functionality when setfalseis that of--no-signing-config.Release Note
--no-signing-configflag to force offline signing by initializing an empty signing config--use-signing-configflag