fix(prefer-export-from): type-import removed when using namespace import
#2771
+119
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
prefer-export-from): type-import removed when using namespace import
k-yle
force-pushed
the
kh/namespace-import-type
branch
from
59b7962 to
deda324
Compare
fisker
reviewed
Oct 9, 2025
| `␊ | ||
| 1 |␊ | ||
| 2 |␊ | ||
| 3 | export type * as X from 'foo';␊ |
Collaborator
There was a problem hiding this comment.
This one seems unsafe to autofix, the imported module may have side effects.
Contributor
Author
There was a problem hiding this comment.
good point, fixed in deda324...4345915.
the other cases get import type, this case does not.
k-yle
force-pushed
the
kh/namespace-import-type
branch
from
deda324 to
4345915
Compare
fisker
reviewed
Oct 13, 2025
| `␊ | ||
| 1 |␊ | ||
| 2 |␊ | ||
| 3 | export * as X from 'foo';␊ |
Collaborator
There was a problem hiding this comment.
I think this also change the behavior, it only expose type before, now it expose values. Maybe we can export type but not remove the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this code:
is autofixed to this:
which is missing the
typemodifier.This PR fixes the issue. First commit adds a test case, second commit fixes the bug