Skip to content

Union support for Simplify* - #1178

Closed
benzaria wants to merge 4 commits into
sindresorhus:mainfrom
benzaria:Simplify/Union
Closed

benzaria wants to merge 4 commits into
sindresorhus:mainfrom
benzaria:Simplify/Union

Conversation

@benzaria

@benzaria benzaria commented Jun 8, 2025 •

Copy link
Copy Markdown
Contributor

Add Simplify* support for unions

  • fix: Simplify return {} for functions.
  • feat: update Simplify to use ConditionalSimplify
  • feat: refactor ConditionalSimplify and ConditionalSimplifyDeep types for Union support and improved clarity.
  • feat: add new tests covering these changes.
  • feat: remove unnecessary interface in ConditionalSimplifyDeep test file (TODO)
  • doc: improve jsDoc for Simplify and SimplifyDeep

benzaria added 3 commits June 8, 2025 02:49
 - fix: `Simplify` return `{}` for functions.
 - feat: refactor `ConditionalSimplify` and `ConditionalSimplifyDeep` types for Union support and improved clarity.
 - feat: add new test covering these changes.
 - feat: remove unnecessary interface in `ConditionalSimplifyDeep` test file (TODO)
 - doc: improve jsDoc for `Simplify` and `SimplifyDeep`
@benzaria benzaria changed the title Union support for Simplify Union support for Simplify* Jun 8, 2025
@benzaria
benzaria marked this pull request as draft June 8, 2025 22:57
@benzaria benzaria mentioned this pull request Jun 9, 2025
1 task done
@sindresorhus

Copy link
Copy Markdown
Owner

Let's do a separate SimplifyUnion type.

@benzaria

Copy link
Copy Markdown
Contributor Author

Let's do a separate SimplifyUnion type.

For sure, it got complicated real quick!

@benzaria benzaria mentioned this pull request Oct 13, 2025
@benzaria benzaria closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants