-
Notifications
You must be signed in to change notification settings - Fork 699
[ENH] Baseclass based on dataset-version-a #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @fkiraly, I tried adding the notebook to the PR, but it fails a lot of pre-commit checks when i commit it, is there any way i can easily skip the whole the file from pre-commit tests? |
FYI @agobbifbk, @fkiraly, please look into the approach, here we are using |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
=======================================
Coverage ? 84.68%
=======================================
Files ? 49
Lines ? 5647
Branches ? 0
=======================================
Hits ? 4782
Misses ? 865
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR implements
BaseModel
class based ondataset-version-a
Colab example: https://colab.research.google.com/drive/1Tk0yLWPm3eqXWyC3ptIVTBLlmsoKWK2h?usp=sharing