Skip to content

Conversation

phoeenniixx
Copy link
Member

Description

This PR implements BaseModel class based on dataset-version-a

Colab example: https://colab.research.google.com/drive/1Tk0yLWPm3eqXWyC3ptIVTBLlmsoKWK2h?usp=sharing

@phoeenniixx
Copy link
Member Author

Hi @fkiraly, I tried adding the notebook to the PR, but it fails a lot of pre-commit checks when i commit it, is there any way i can easily skip the whole the file from pre-commit tests?

@phoeenniixx
Copy link
Member Author

FYI @agobbifbk, @fkiraly, please look into the approach, here we are using metadata param for the model to initialise the model

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

❌ Patch coverage is 52.89017% with 163 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@4d54ad6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/models/base_model_lightning.py 0.00% 73 Missing ⚠️
...odels/temporal_fusion_transformer/tft_new_basic.py 0.00% 68 Missing ⚠️
pytorch_forecasting/data/data_modules.py 89.67% 16 Missing ⚠️
pytorch_forecasting/data/timeseries.py 88.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage        ?   84.68%           
=======================================
  Files           ?       49           
  Lines           ?     5647           
  Branches        ?        0           
=======================================
  Hits            ?     4782           
  Misses          ?      865           
  Partials        ?        0           
Flag Coverage Δ
cpu 84.68% <52.89%> (?)
pytest 84.68% <52.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phoeenniixx
Copy link
Member Author

phoeenniixx commented May 13, 2025

We are finally moving on with the version-b of this implementation, See #1791(draft implementation),
#1811, #1812, #1813 (Final PRs with a basic model implementation and vignette)

FYI @fkiraly, @PranavBhatP @agobbifbk

@github-project-automation github-project-automation bot moved this from PR under review to Done in Dec 2024 - Mar 2025 mentee projects May 13, 2025
@phoeenniixx phoeenniixx deleted the baseclass branch May 13, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant