-
Notifications
You must be signed in to change notification settings - Fork 699
[ENH] EXPERIMENTAL: TFT model based on the new data pipeline #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
=======================================
Coverage ? 84.20%
=======================================
Files ? 53
Lines ? 5836
Branches ? 0
=======================================
Hits ? 4914
Misses ? 922
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
But you did everything right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
May I just ask for minor changes:
- in the base model, include the warning message like in the data modules. Make a reference to
self
to also give hte user the name of the model - make the new modules private
- I would suggest to use
v2
as an abbreviation, i.e.,_base_model_v2
and_tft_v2
.
Hi @fkiraly, I think this PR is ready to merge |
Description
This PR implements the tft model based on the new data pipeline. This PR is branched off from #1811