Skip to content

Conversation

jobs-git
Copy link
Contributor

@jobs-git jobs-git commented Jun 5, 2025

Add timeseries integration test for various models

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, thanks!!

One change request, could you kindly add it instead to the class named TestAllPtForecasters as a new test?

To loop over all classes like you are doing, use the object_class fixture, like in test_doctest_examples - this will take values of the models.

(not all are retieved at the moment, they require a metadata class like DeepARMetadata - but adding more metadata records would also be a nice contribution later)

@fkiraly fkiraly added the enhancement New feature or request label Jun 5, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented Jun 5, 2025

(also, code formatting fails - I suggest to set up pre-commit locally - works like this https://www.sktime.net/en/stable/developer_guide/coding_standards.html)

@jobs-git jobs-git changed the title [ENH] Add timeseries integration test for various models [WIP] [ENH] Add timeseries integration test for various models Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants