[BUG] Fixing bug #1930 with proper syntax #1950
Open
+46
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cngmid
requested review from
benHeid,
fkiraly,
fnhirwa,
jdb78 and
yarnabrina
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
=======================================
Coverage ? 87.06%
=======================================
Files ? 136
Lines ? 8626
Branches ? 0
=======================================
Hits ? 7510
Misses ? 1116
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cngmid
changed the title
fkiraly
reviewed
Aug 20, 2025
| """ | ||
| if not isinstance(cols, list) and cols not in data.columns: | ||
| return None | ||
| if isinstance(cols, list) and len(cols) == 0: | ||
| dtypekind = "f" | ||
| elif isinstance(cols, list): # and len(cols) > 0 | ||
| dtypekind = data.dtypes[cols[0]].kind | ||
| # dtypekind = data.dtypes[cols[0]].kind | ||
| dtypekind = data[cols].to_numpy().dtype.kind |
There was a problem hiding this comment.
why are we doing this? It feels wasteful to do the conversion for the entire data container, instead of looking up the dtype.
fkiraly
requested changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1930.
When
time_idxor some other integer feature is included in the unknow reals, the dataset/dataloader elements are converted into the wrong dtype.What does this implement/fix? Explain your changes.
Modify the function the method
TimeSeriesDataSet._data_to_tensors._to_tensor()What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Added test function to
tests/test_data/test_timeseries.pyAny other comments?
PR checklist