Skip to content

Conversation

ParamThakkar123
Copy link

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This Pull request adds metadata testing for models and data modules for ptf-v2. I have added ConfigBase for the EncoderDecoderTimeSeriesDataModule and the TslibDataModule. Added new classes specific to each of data modules like for models using EncoderDecoderTimeSeriesDataModule I added EncoderDecoderConfigBase and for TslibDataModule I added TslibConfigBase

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Yes, All tests passes locally

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 59.64912% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@a3bc452). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/models/base/_base_object.py 19.04% 17 Missing ⚠️
...orch_forecasting/models/dlinear/_dlinear_pkg_v2.py 80.00% 1 Missing ⚠️
..._forecasting/models/samformer/_samformer_v2_pkg.py 80.00% 1 Missing ⚠️
.../models/temporal_fusion_transformer/_tft_pkg_v2.py 80.00% 1 Missing ⚠️
...recasting/models/tide/_tide_dsipts/_tide_v2_pkg.py 80.00% 1 Missing ⚠️
...orch_forecasting/models/timexer/_timexer_pkg_v2.py 80.00% 1 Missing ⚠️
...ytorch_forecasting/tests/test_all_estimators_v2.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1973   +/-   ##
=======================================
  Coverage        ?   87.04%           
=======================================
  Files           ?      158           
  Lines           ?     9354           
  Branches        ?        0           
=======================================
  Hits            ?     8142           
  Misses          ?     1212           
  Partials        ?        0           
Flag Coverage Δ
cpu 87.04% <59.64%> (?)
pytest 87.04% <59.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, interesting idea!

I am a bit confused about the logic here. I assume that you intend the new test test_d2_metadata to retrieve the new classes that you added, but this will not happen? Since the object_pkg variable will be, for instance, TimeXer_pkg_v2, but that class will never have the check method?

Design-wise, I think the best place to locate the checker method is imo not the model package class, but the D2 layer data class that produces the metadata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants