-
Notifications
You must be signed in to change notification settings - Fork 708
[BUG] Standardize output format of NBeats and NBeatsKAN estimators #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Standardize output format of NBeats and NBeatsKAN estimators #1977
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
=======================================
Coverage ? 86.77%
=======================================
Files ? 160
Lines ? 9475
Branches ? 0
=======================================
Hits ? 8222
Misses ? 1253
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm not sure why this particular test is failing in CI. When I run |
The tests are passing because it is currently skipped for |
The model we are concerned about is NBeats not NHiTS right... |
Ah yes, you’re right—my bad! The test I ran locally was for NHiTS, but the model in my PR is NBeats. I just wanted to check that the changes I made didn’t break the workflow for a similar model. |
Thanks for the changes! |
Hey, just wanted to check if there’s anything else needed from my side before it can be merged. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR updates the NBeatsAdapter to ensure that both NBeats and NBeatsKAN models return 3D tensors (batch_size, prediction_length, 1) for point predictions, aligning with the expected output format #1975.