[BUG] Return a boolean fitted state from MultiNormalizer - #2404
Open
marco-trotta1 wants to merge 3 commits into
Open
[BUG] Return a boolean fitted state from MultiNormalizer#2404marco-trotta1 wants to merge 3 commits into
marco-trotta1 wants to merge 3 commits into
Conversation
marco-trotta1
requested review from
benHeid,
fkiraly,
jdb78 and
phoeenniixx
as code owners
September 3, 2026 02:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage ? 88.29%
=======================================
Files ? 200
Lines ? 11170
Branches ? 0
=======================================
Hits ? 9862
Misses ? 1308
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM generated content, by GPT-5.6
Reference Issues/PRs
Fixes #1806.
What does this implement/fix? Explain your changes.
MultiNormalizernow reduces delegated__sklearn_is_fitted__results withall(). Other delegated methods continue to return their result lists.What should a reviewer concentrate their feedback on?
MultiNormalizeras unfitted.__sklearn_is_fitted__.Did you add any tests for the change?
Yes. The regression test covers unfitted, partially fitted, and fully fitted pipeline normalizers.
Any other comments?
The focused tests pass on macOS with Python 3.11. The repository-wide legacy model integration tests encounter existing MPS-specific failures.
PR checklist
[BUG].Scoped Ruff 0.6.9 format and lint checks passed.