Skip to content

[BUG] Return a boolean fitted state from MultiNormalizer - #2404

Open
marco-trotta1 wants to merge 3 commits into
sktime:mainfrom
marco-trotta1:fix/multinormalizer-fitted-state
Open

[BUG] Return a boolean fitted state from MultiNormalizer#2404
marco-trotta1 wants to merge 3 commits into
sktime:mainfrom
marco-trotta1:fix/multinormalizer-fitted-state

Conversation

@marco-trotta1

Copy link
Copy Markdown

LLM generated content, by GPT-5.6

Reference Issues/PRs

Fixes #1806.

What does this implement/fix? Explain your changes.

MultiNormalizer now reduces delegated __sklearn_is_fitted__ results with all(). Other delegated methods continue to return their result lists.

What should a reviewer concentrate their feedback on?

  • Confirm that partially fitted pipeline normalizers report the whole MultiNormalizer as unfitted.
  • Confirm that result lists remain unchanged for methods other than __sklearn_is_fitted__.

Did you add any tests for the change?

Yes. The regression test covers unfitted, partially fitted, and fully fitted pipeline normalizers.

Any other comments?

The focused tests pass on macOS with Python 3.11. The repository-wide legacy model integration tests encounter existing MPS-specific failures.

PR checklist

  • The PR title starts with [BUG].
  • Added or modified tests.
  • Ran all pre-commit hooks.

Scoped Ruff 0.6.9 format and lint checks passed.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@67c354f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage        ?   88.29%           
=======================================
  Files           ?      200           
  Lines           ?    11170           
  Branches        ?        0           
=======================================
  Hits            ?     9862           
  Misses          ?     1308           
  Partials        ?        0           
Flag Coverage Δ
cpu 88.29% <100.00%> (?)
pytest 88.29% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MultiNormalizer on __sklearn_is_fitted__ function call returns [false/true, false/true, ...] list

1 participant