[ENH] Improve error handling of _get_data_by_filename in data/examples.py - #2405
Open
victorwon2001 wants to merge 1 commit into
Open
[ENH] Improve error handling of _get_data_by_filename in data/examples.py#2405victorwon2001 wants to merge 1 commit into
victorwon2001 wants to merge 1 commit into
Conversation
victorwon2001
requested review from
benHeid,
fkiraly,
jdb78 and
phoeenniixx
as code owners
September 3, 2026 09:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
=======================================
Coverage ? 88.20%
=======================================
Files ? 200
Lines ? 11174
Branches ? 0
=======================================
Hits ? 9856
Misses ? 1318
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM generated content, by GPT-5.6 Sol
Reference Issues/PRs
Fixes #2152
What does this implement/fix? Explain your changes.
Downloads for uncached example data are now written to a temporary directory under the cache location and moved to the final cache path only after
urlretrieve()completes successfully. Failed transfers therefore do not leave a partial file that a later call could mistake for a valid cached download, while existing cache-hit behavior and download exceptions remain unchanged.What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes. Regression tests cover cache hits, successful publication, cleanup after partial
ContentTooShortErrorandURLErrorfailures, and retrying after a failed download. The focused tests, the fulltests/test_datasuite, and pre-commit checks pass; repository-wide pytest runs were interrupted before completion with no failures observed before termination.Any other comments?
None.
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files