package-lock.json
#241
Merged
package-lock.json
#241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for following up. A couple comments:
Thanks again! |
|
|
Btw, |
|
Hmm, sure enough, it does: https://travis-ci.org/slevithan/xregexp/builds/370310563 I think we should pin Travis to Node v9 for now, and figure out the v10 issue separately later. I'll make a PR for that. |
josephfrazier
added a commit
to josephfrazier/xregexp
that referenced
this pull request
Apr 26, 2018
v10 fails currently: https://travis-ci.org/slevithan/xregexp/builds/370310563#L510-L528 ``` Failures: 1) XRegExp() supports new regex syntax: named capture should throw an exception if characters other than A-Z, a-z, 0-9, $, and _ are used in capture names Message: Expected function to throw an Error. Stack: Error: Expected function to throw an Error. at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:407:61) Message: Expected function to throw an Error. Stack: Error: Expected function to throw an Error. at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:408:63) Message: Expected function to throw an Error. Stack: Error: Expected function to throw an Error. at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:409:59) 398 specs, 1 failure ``` See also slevithan#241 (comment)
josephfrazier
added a commit
that referenced
this pull request
Apr 26, 2018
v10 fails currently: https://travis-ci.org/slevithan/xregexp/builds/370310563#L510-L528 ``` Failures: 1) XRegExp() supports new regex syntax: named capture should throw an exception if characters other than A-Z, a-z, 0-9, $, and _ are used in capture names Message: Expected function to throw an Error. Stack: Error: Expected function to throw an Error. at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:407:61) Message: Expected function to throw an Error. Stack: Error: Expected function to throw an Error. at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:408:63) Message: Expected function to throw an Error. Stack: Error: Expected function to throw an Error. at UserContext.<anonymous> (/home/travis/build/slevithan/xregexp/tests/spec/s-xregexp.js:409:59) 398 specs, 1 failure ``` See also #241 (comment)
|
I just merged #242, so feel free to rebase this branch onto master |
- Linting: Fixes for newly-enforced (indentation) ESLint rules
|
Sorry for the last comment (just deleted)--no problems in this PR so feel free to merge if ok... |
|
Thanks, it looks great! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package-lock.json(Changes as discussed in #234)