[sui] FeeQuoter fixes - #1217
Merged
Merged
Conversation
stackman27
changed the title
stackman27
marked this pull request as ready for review
September 30, 2025 18:31
stackman27
marked this pull request as draft
September 30, 2025 19:23
jhweintraub
previously approved these changes
Sep 30, 2025
FelixFan1992
previously approved these changes
Oct 1, 2025
RensR
requested changes
Oct 2, 2025
| // Code generated - DO NOT EDIT. | ||
| // This file is a generated binding and any manual changes will be lost. | ||
|
|
||
| package message_hasher |
Collaborator
There was a problem hiding this comment.
This can never change. Undo any changes to previous releaes.
RensR
reviewed
Oct 2, 2025
| // Code generated - DO NOT EDIT. | ||
| // This file is a generated binding and any manual changes will be lost. | ||
|
|
||
| package fee_quoter |
Collaborator
There was a problem hiding this comment.
These should only be populated during a release. Please remove the 1.6.3 folder
Collaborator
|
Please add an entry in the changelog to add a section for 1.6.3 that includes this in its scope |
RensR
reviewed
Oct 2, 2025
| uint256 public constant KEYSTONE_PRICE_DECIMALS = 18; | ||
|
|
||
| string public constant override typeAndVersion = "FeeQuoter 1.6.3-dev"; | ||
| string public constant override typeAndVersion = "FeeQuoter 1.6.3"; |
Collaborator
There was a problem hiding this comment.
This may only be changed on a release, not prior.
stackman27
marked this pull request as ready for review
October 7, 2025 15:31
FelixFan1992
previously approved these changes
Oct 7, 2025
RensR
reviewed
Oct 7, 2025
RensR
reviewed
Oct 7, 2025
RensR
reviewed
Oct 7, 2025
RensR
previously approved these changes
Oct 8, 2025
RensR
approved these changes
Oct 8, 2025
Merged
FelixFan1992
approved these changes
Oct 8, 2025
FelixFan1992
enabled auto-merge
October 8, 2025 17:14
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.