deployment: Set OCR3 config #1233
Conversation
| ConfigDigest: configForOCR3.ConfigDigest, | ||
| OcrPluginType: uint8(pluginType), | ||
| F: configForOCR3.Config.FRoleDON, | ||
| IsSignatureVerificationEnabled: pluginType == ccipocr3.PluginTypeCCIPCommit, |
There was a problem hiding this comment.
ccipocr3.PluginType was recently added by @ogtownsend to common, we should use them everywhere in core as well and retire the old types
| CapabilityVersion = "v1.0.0" | ||
| ) | ||
|
|
||
| var CCIPCapabilityID = hashutil.NewKeccak().Hash(mustABIEncode(`[{"type": "string"}, {"type": "string"}]`, CapabilityLabelledName, CapabilityVersion)) |
There was a problem hiding this comment.
We need to do something like this in core too, a lot of unnecessary "github.com/smartcontractkit/chainlink-evm/pkg/utils" imports
deployment/v1_6/set_ocr3_config.go
Outdated
| state.Chains[homeChainSelector].CapabilityRegistry, | ||
| state.Chains[homeChainSelector].CCIPHome, |
There was a problem hiding this comment.
What should we do here? Need to avoid the stateview dep?
There was a problem hiding this comment.
something like this I think
homeFamily, err := chain_selectors.GetSelectorFamily(homeChainSelector)
if err != nil {
return nil, err
}
ccipHome, err := registeredChainAdapters[homeFamily].GetCCIPHome(e, homeChainSelector)
if err != nil {
return nil, err
}
capabilityRegistry, err := registeredChainAdapters[homeFamily].GetCapabilityRegistry(e, homeChainSelector)
if err != nil {
return nil, err
}
donID, err := internal.DonIDForChain(
ccipHome,
capabilityRegistry,
chainSelector,
)
if err != nil {
return nil, fmt.Errorf("failed to get DON ID: %w", err)
}
deployment/go.mod
Outdated
| github.com/smartcontractkit/chainlink-ccip v0.1.1-solana.0.20250911201806-5a095deaeb52 | ||
| github.com/smartcontractkit/chainlink-common v0.9.6-0.20250930212138-0b782340a7f5 | ||
| github.com/smartcontractkit/chainlink-deployments-framework v0.44.0 | ||
| github.com/smartcontractkit/chainlink-evm/gethwrappers v0.0.0-20250827130336-5922343458be |
There was a problem hiding this comment.
I made sure we depend on gethwrappers only, chainlink-evm/pkg should be an auto-deny lint
There was a problem hiding this comment.
Yeah let's set up a linter for this separately.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tt-cll
requested review from
0xAustinWang,
KodeyThomas,
chris-de-leon-cll,
mateusz-sekara,
ogtownsend and
winder
|
| GetOffRampAddress(e *cldf.Environment, chainSelector uint64) ([]byte, error) | ||
| GetRouterAddress(e *cldf.Environment, chainSelector uint64) ([]byte, error) | ||
| GetFQAddress(e *cldf.Environment, chainSelector uint64) ([]byte, error) | ||
| GetOnRampAddress(ds datastore.DataStore, chainSelector uint64) ([]byte, error) |
There was a problem hiding this comment.
What's the motivation behind this change?
There was a problem hiding this comment.
basically, we don't need the full environment to fetch the addresses
|
|
||
| func setOCR3ConfigVerify(_ *DeployerRegistry, _ *changesets.MCMSReaderRegistry) func(cldf.Environment, SetOCR3ConfigArgs) error { | ||
| return func(e cldf.Environment, cfg SetOCR3ConfigArgs) error { | ||
| // TODO: implement |
There was a problem hiding this comment.
should we implement it before merging?
There was a problem hiding this comment.
I think we can come back to it later and just unblock for now
3 participants
No description provided.