[CCIP-7268-pt-1] Add ConfigureTokensForTransfers to product spec #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-cll
reviewed
Oct 7, 2025
| m map[tokenAdapterID]TokenAdapter | ||
| } | ||
|
|
||
| func NewTokenAdapterRegistry() *TokenAdapterRegistry { |
There was a problem hiding this comment.
Is there ever a reason we'll want more than one registry in a single runtime instance? It might make sense for this to be a singleton and to just have a GetTokenAdapterRegistry
There was a problem hiding this comment.
The issue I had with the singleton approach was testing. Much easier to create a registries in each test, parallel tests have independent registries.
tt-cll
previously approved these changes
Oct 7, 2025
AnieeG
previously approved these changes
Oct 7, 2025
deployment/tokens/product.go
Outdated
Comment on lines
18
to
21
| type TokenAdapter interface { | ||
| ConfigureTokenForTransfersSequence() *cldf_ops.Sequence[ConfigureTokenForTransfersInput, sequences.OnChainOutput, cldf_chain.BlockChains] | ||
| ConvertRefToBytes(ref datastore.AddressRef) ([]byte, error) | ||
| DeriveRemoteTokenAddress(e deployment.Environment, chainSelector uint64, poolRef datastore.AddressRef) ([]byte, error) |
There was a problem hiding this comment.
some comment on these func would be great
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
* [CCIP-7090] Move chain family agnostic utilities to deployment module * Update top level deploy pkg * Fix, + add test workflows * Checkout * Fix * Fix again * Workflow * Add checkout * OpCount -> GetChainMetadata * Fix tests * Use mcms.Input * Move contract writes back to EVM * [CCIP-7268-pt-1] Add ConfigureTokensForTransfers to product spec * Very WIP * Rm global registry * Test
kylesmartin
dismissed stale reviews from AnieeG and tt-cll
Making some changes
AnieeG
approved these changes
Oct 7, 2025
tt-cll
approved these changes
Oct 7, 2025
|
RensR
added a commit
that referenced
this pull request
Oct 8, 2025
* add owners for deployments (#1239) * owners * owners * add zksync gobinding (#1238) Co-authored-by: kylesmartin <[email protected]> * add warning gobindings (#1235) * Add factory param for LOOPP enabled families (#1231) * Add factory param for LOOPP enabled families * add tests for feature flag map for USDC reader * [CCIP-7090] Move chain family agnostic utilities to deployment module (#1237) * [CCIP-7090] Move chain family agnostic utilities to deployment module * Update top level deploy pkg * Fix, + add test workflows * Checkout * Fix * Fix again * Workflow * Add checkout * OpCount -> GetChainMetadata * Fix tests * Use mcms.Input * Move contract writes back to EVM * Rm global registry * update npm release action (#1252) * CCIP-6698 New USDC Token Pool Proxy for routing USDC messages to the proper token pool (#1134) * begin migrating files from other PR for phase 2 * initial compilation and tests passing. * cleanup and wrapper updates * remove previousPool from the USDC Token Pool as it will be moved to the future proxy * more cleanup * checkpointing * cleanup * productionize * comments and proxy updates * additional comments * forge fmt * bump type and version for future release cuts * wrappers regen * changeset * review comment fixes and test cleanup * formatting and gas optimization * add expectCall to lockOrBurn tests * fix CI from merge conflicts * fix CI from merge conflicts * code review fixes * feedback fixes * comment fix * resolve CI from merge conflicts in previous commit * typo fix * comment fixes and gas optimizations * add additional branches for direct non-transmitter-proxy upgrades * better comments and gas optimization * gobindings and comment fix * simplify proxy by removing tokenPool dependency * linter fix * constructor input sanitization check * modify lock release pools to be dynamic based on remote chain selector * fix dependency pathing * fix comment feedback * Change source pool data codec * update encoding schemes for more specific versioning * cleanup * fill in coverage test gaps * comment fixes and PoolV1 interface support for proxy * productionize codec library * add cctp fast transfer version tag * snapshot fix * remove superfluous constructor checks * forge fmt * comment feedback fixes * fill in coverage gaps and add new tokenPoolProxy helper contract. * *spiderman voice* let's try this one last time * deposit hash validation on destination * more fuzz tests and better message formatting comments * wrapper and snapshot fix from merge conflict resolution * add support for legacy source pool data format to prevent breaking changes * additional library test files, hash collision prevention, and better commenting * cld ccip api e2e (#1227) * wip * flatten * flatten * iterate * iterate * iterate * iterate * iterate * iterate * iterate * seed solana * move ref * [CCIP-7268-pt-1] Add ConfigureTokensForTransfers to product spec (#1242) * [CCIP-7090] Move chain family agnostic utilities to deployment module * Update top level deploy pkg * Fix, + add test workflows * Checkout * Fix * Fix again * Workflow * Add checkout * OpCount -> GetChainMetadata * Fix tests * Use mcms.Input * Move contract writes back to EVM * [CCIP-7268-pt-1] Add ConfigureTokensForTransfers to product spec * Very WIP * Rm global registry * Test * Comments * prevent breaking o11y with idl changes (#1247) * prevent breaking o11y with idl changes * test change idl * fix action * fix * change in idl * only ones we need to track * Revert "change in idl" This reverts commit 8378c29. * shouldn't trigger * should detect multiple * fix actin * Revert "should detect multiple" This reverts commit 1a8fd3d. * Revert "shouldn't trigger" This reverts commit c4e8ef2. * fix some comms * add unlabeled * should trigger * Revert "add unlabeled" This reverts commit 79a1d6c. * unlabeled * Revert "should trigger" This reverts commit b47dd70. * fix missing permissions for ID token (#1254) * fix missing permissions for ID token * move to job level * Validate dest pool in FTF pool (#1251) * add validation for destination pool * add tests * update wrapper * update comment + refactor * lint fix * update changesets setup --------- Co-authored-by: tt-cll <[email protected]> Co-authored-by: Matthew Romage <[email protected]> Co-authored-by: kylesmartin <[email protected]> Co-authored-by: Oliver Townsend <[email protected]> Co-authored-by: Josh Weintraub <[email protected]> Co-authored-by: Juan Farber <[email protected]> Co-authored-by: Suryansh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://smartcontract-it.atlassian.net/browse/CCIP-7268