Skip to content

pkg/types/solana: move CR/CW config types from solana repo #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2025
Merged

pkg/types/solana: move CR/CW config types from solana repo #1308

merged 4 commits into from
Aug 22, 2025

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jun 28, 2025 •
edited
Loading

This was referenced Jun 28, 2025
Draft
Draft
@jmank88 jmank88 marked this pull request as ready for review June 28, 2025 16:35
@jmank88 jmank88 requested a review from a team as a code owner June 28, 2025 16:35
ilija42
ilija42 previously approved these changes Jun 30, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 31, 2025
@jmank88 jmank88 removed the Stale label Aug 1, 2025
@jmank88 jmank88 requested a review from ilija42 August 19, 2025 23:32
ilija42
ilija42 reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the goal here?

@jmank88
Copy link
Contributor Author

jmank88 commented Aug 20, 2025

Whats the goal here?

To unblock loopp build separation by allowing clients to use only the common module instead of importing chain modules for types to serialize as json.

@jmank88 jmank88 requested a review from ilija42 August 20, 2025 12:03
@jmank88 jmank88 enabled auto-merge (squash) August 20, 2025 14:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

apidiff results - no incompatible changes detected ✅

Module: github-com-smartcontractkit-chainlink-common

Status: ✅ 1 compatible changes

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17159820611/#summary-48685925084)

@jmank88 jmank88 merged commit db9b1bc into main Aug 22, 2025
18 of 19 checks passed
@jmank88 jmank88 deleted the pkg/types/solana branch August 22, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@ilija42 ilija42 ilija42 approved these changes

@mchain0 mchain0 Awaiting requested review from mchain0 mchain0 is a code owner automatically assigned from smartcontractkit/foundations

@krebernisak krebernisak Awaiting requested review from krebernisak

@archseer archseer Awaiting requested review from archseer

@cfal cfal Awaiting requested review from cfal

@krehermann krehermann Awaiting requested review from krehermann

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@bolekk bolekk Awaiting requested review from bolekk

@nolag nolag Awaiting requested review from nolag

@anirudhwarrier anirudhwarrier Awaiting requested review from anirudhwarrier

@huangzhen1997 huangzhen1997 Awaiting requested review from huangzhen1997

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @cedric-cordenier @ilija42