WIP: DF-21462 Make ReportingPluginFactory generic #1525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we want to use protobuf in between (because of loopps) and protobuf doesn't support generic types, let's use a type constraint so that it can be marshalled to and from []byte.
cll-gg
changed the title
any for ReportingPluginFactory's type.
apidiff results - no modules to analyze |
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR has been automatically closed because it has been stale for > 30 days. |
github-actions
bot
deleted the
DF-21462-make-reporting-plugin-factory-generic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
libocr uses
anyfor ReportingPluginFactory's type.Since we want to use protobuf in between (because of loopps) and protobuf doesn't support generic types, let's use a type constraint so that it can be marshalled to and from []byte.
Requires
Supports