fix: make config files & evm/tron chain load optional #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce298d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
graham-chainlink
changed the title
Fixes issue where users needed dummy config files with deployer keys to analyze MCMS proposals locally. Context: https://chainlink-core.slack.com/archives/C08QF1BEW4T/p1761128244593229 Changes: - Config files now optional, falls back to environment variables - EVM and Tron chains only load when credentials provided (key or KMS) - Added tests for optional config and credential scenarios Users can now analyze proposals without credentials by using: environment.WithoutJD() + environment.OnlyLoadChainsFor([]uint64{}) No breaking changes.
graham-chainlink
force-pushed
the
ggoh/optional-config
branch
from
567a4b8 to
ce298d0
Compare
|
There was a problem hiding this comment.
Pull Request Overview
This PR makes configuration files and blockchain credentials optional, allowing users to analyze MCMS proposals without needing dummy config files or credentials.
Key changes:
- Configuration now falls back to environment variables when local config files don't exist
- EVM and Tron chain loaders only initialize when credentials (deployer key or KMS config) are provided
- Added comprehensive test coverage for optional configurations and credential scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| engine/cld/config/env.go | Updated to use cfgenv.Load() for fallback behavior and documented the new loading strategy |
| engine/cld/config/config_test.go | Modified test to verify fallback to environment variables when config file is missing |
| engine/cld/chains/chains.go | Added conditional loading logic for EVM and Tron chains based on credential availability |
| engine/cld/chains/chains_test.go | Added comprehensive tests for different credential scenarios |
| .changeset/some-plants-doubt.md | Added changeset documenting the patch-level change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where users needed dummy config files with evm deployer key to analyze MCMS proposals locally.
Context: https://chainlink-core.slack.com/archives/C08QF1BEW4T/p1761128244593229
Changes:
Users can now analyze proposals without credentials.
No breaking changes.