MCMS: Add WrongNonce error for EVM to skip #539
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for the WrongNonce error in the EVM nonce error detection logic. The change allows the system to skip operations that encounter either WrongNonce or the existing PostOpCountReached error.
Key Changes:
- Extended the nonce error check to include
WrongNoncealongsidePostOpCountReached
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| decodedErr := cldf.DecodeErr(bindings.ManyChainMultiSigABI, rawErr) | ||
| // Check if the error contains PostOpCountReached | ||
| if strings.Contains(decodedErr.Error(), "PostOpCountReached") { | ||
| if strings.Contains(decodedErr.Error(), "WrongNonce") || strings.Contains(decodedErr.Error(), "PostOpCountReached") { |
There was a problem hiding this comment.
The error string is being searched twice with decodedErr.Error(). Consider storing the error string in a variable to avoid calling .Error() twice.
| if strings.Contains(decodedErr.Error(), "WrongNonce") || strings.Contains(decodedErr.Error(), "PostOpCountReached") { | |
| errStr := decodedErr.Error() | |
| if strings.Contains(errStr, "WrongNonce") || strings.Contains(errStr, "PostOpCountReached") { |
simsonraj
changed the title
|
| switch family { | ||
| case chainsel.FamilyEVM: | ||
| decodedErr := cldf.DecodeErr(bindings.ManyChainMultiSigABI, rawErr) | ||
| // Check if the error contains PostOpCountReached |
There was a problem hiding this comment.
The comment should be updated as well to reflect the change
3 participants
https://github.com/smartcontractkit/chainlink-deployments/actions/runs/18708625042/job/53468267687
EVM is missing
WrongNoncedecoded error to run the execute withskip-nonce-errors, which just happened on Sonic