feat: add job filter to memory client #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61b1769 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jkongie
commented
Oct 24, 2025
| // Also create a job based on the proposal | ||
| job := &jobv1.Job{ | ||
| Id: jobID, | ||
| Uuid: uuid.New().String(), |
There was a problem hiding this comment.
This fixes the field which should have been set during job setup
jkongie
commented
Oct 24, 2025
| if proposal.JobId == jobID { | ||
| delete(m.proposals, id) | ||
| } | ||
| job, ok := m.jobs[jobID] |
There was a problem hiding this comment.
Implement a soft delete instead to match the Job Distributor API
jkongie
commented
Oct 24, 2025
| // Unknown operation, default to false | ||
| return false | ||
| } | ||
| return matchesSelector(nodeLabels, selector) |
There was a problem hiding this comment.
Clean up to use a common function
jkongie
commented
Oct 24, 2025
| node: &nodev1.Node{ | ||
| Labels: []*ptypes.Label{ | ||
| {Key: "environment", Value: pointer.To("prod")}, | ||
| }, |
There was a problem hiding this comment.
These tests are now covered by the common function
jkongie
force-pushed
the
jd-memory-client-job-filter
branch
from
3ce4762 to
7ae3fe6
Compare
When calling `ListJobs`, the filter can now be applied to the jobs. This supports all the filter options that are supported by the `ListJobs` method. It also makes a change to the DeleteJob method to perform a soft delete of the job, rather than a hard delete. This is in line with how the Job Distributor API works.
jkongie
force-pushed
the
jd-memory-client-job-filter
branch
from
7ae3fe6 to
61b1769
Compare
|
giogam
approved these changes
Oct 24, 2025
| func jobMatchesNodeIds(job *jobv1.Job, nodeIds []string) bool { | ||
| return slices.Contains(nodeIds, job.NodeId) | ||
| } | ||
|
|
There was a problem hiding this comment.
Could these 3 function be a general jobMatches function since they have the same signature and perform the same check?
eg
func jobMatches(target string, filter []string) bool {
return slices.Contains(filter, target)
}
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#536](#536) [`d35d8de`](d35d8de) Thanks [@jkongie](https://github.com/jkongie)! - JD Memory Client now supports filtering in `ListNodes` - [#542](#542) [`5b3a421`](5b3a421) Thanks [@jkongie](https://github.com/jkongie)! - Aligns MemoryJobDistributor `ProposeJob` and `RevokeJob` to have the same functionality as the JobDistributor service - [#540](#540) [`35d9189`](35d9189) Thanks [@jkongie](https://github.com/jkongie)! - JD Memory Client now supports filtering in `ListJobs` --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
ListJobs, the filter can now be applied to the jobs.This supports all the filter options that are supported by the
ListJobsmethod. It also makes a change to the DeleteJob method to perform a soft delete of the job, rather than a hard delete. This is in line with how the Job Distributor API works.