feat(operations): add always-execute option and latest cache reuse#925
Draft
graham-chainlink wants to merge 1 commit intomainfrom
Draft
feat(operations): add always-execute option and latest cache reuse#925graham-chainlink wants to merge 1 commit intomainfrom
graham-chainlink wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 6fbfc43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
graham-chainlink
force-pushed
the
ggoh/NOJIRA/operations-always-execute-cache
branch
from
2b36801 to
fd83eaa
Compare
Introduce WithAlwaysExecute for operations to bypass previous successful report reuse when explicitly requested. Also ensure cached report lookup prefers the most recent successful match and add regression coverage plus docs updates.
graham-chainlink
force-pushed
the
ggoh/NOJIRA/operations-always-execute-cache
branch
from
fd83eaa to
6fbfc43
Compare
|
| } | ||
|
|
||
| for _, report := range prevReports { | ||
| for i := len(prevReports) - 1; i >= 0; i-- { |
Collaborator
Author
There was a problem hiding this comment.
now that there can be multiple reports of the same ID, we want to return the most recent ones instead of the oldest one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
WithAlwaysExecuteexecute option to force operation execution and bypass previous successful report short-circuiting.Why