Skip to content

Return err on db failure - #1611

Open
yashnevatia wants to merge 1 commit into
developfrom
return-err-on-db-failure
Open

Return err on db failure#1611
yashnevatia wants to merge 1 commit into
developfrom
return-err-on-db-failure

Conversation

@yashnevatia

Copy link
Copy Markdown
Contributor

Description

Requires Dependencies

Resolves Dependencies

@github-actions

Copy link
Copy Markdown
Contributor

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-solana

⚠️ Breaking Changes (10)

pkg/solana.LogPoller (1)
  • HasFilter — Type changed:
func(
  context.Context, 
  string
)
- bool
+ (bool, error)
pkg/solana/ccip/chainaccessor.AccessorLogPoller (1)
  • HasFilter — Type changed:
func(
  context.Context, 
  string
)
- bool
+ (bool, error)
pkg/solana/chainreader.EventsReader (1)
  • HasFilter — Type changed:
func(
  context.Context, 
  string
)
- bool
+ (bool, error)
pkg/solana/chainreader/mocks.(*EventsReader) (1)
  • HasFilter — Type changed:
func(
  context.Context, 
  string
)
- bool
+ (bool, error)
pkg/solana/chainreader/mocks.(*EventsReader_HasFilter_Call) (2)
  • Return — Type changed:
func(
  bool, 
  + error
)
*EventsReader_HasFilter_Call
  • RunAndReturn — Type changed:
func(
  func(context.Context, 
  - string) bool
  + string) (bool, 
  + error)
)
*EventsReader_HasFilter_Call
pkg/solana/logpoller.(*Service) (1)
  • HasFilter — Type changed:
func(
  context.Context, 
  string
)
- bool
+ (bool, error)
pkg/solana/logpoller/mocks.(*MockFilters) (1)
  • HasFilter — Type changed:
func(
  context.Context, 
  string
)
- bool
+ (bool, error)
pkg/solana/logpoller/mocks.(*MockFilters_HasFilter_Call) (2)
  • Return — Type changed:
func(
  bool, 
  + error
)
*MockFilters_HasFilter_Call
  • RunAndReturn — Type changed:
func(
  func(context.Context, 
  - string) bool
  + string) (bool, 
  + error)
)
*MockFilters_HasFilter_Call

📄 View full apidiff report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant