Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the health check capabilities for the Job Distributor (JD) component by introducing a new gRPC health check strategy and updating the CI pipeline to test JD startup using private container images. It also refactors the JD test to reside in the examples directory, improves port management in JD startup logic, and updates dependencies for gRPC support.
JD Health Check Improvements
GRPCHealthStrategyingrpc_wait_strategy.goto perform robust gRPC health checks on the JD container during startup. This strategy uses the standard gRPC health protocol and supports configurable timeouts and polling intervals.jd.goto expose both the main gRPC port and a separate health check port, and to use the new gRPC health check strategy as part of the container's wait conditions. Also added a check to prevent port conflicts between WSRPC and its health endpoint. [1] [2] [3] [4] [5]CI Pipeline Enhancements
framework-golden-tests-private.yml) to run JD tests that require access to private container registries, including AWS ECR authentication and log upload.Test Refactoring
components/jd/jd_test.gotoexamples/myproject/jd_test.go, renamed the test for clarity, and added a random CSA encryption key for improved test isolation.Dependency Updates
go.modfiles to include or bump thegoogle.golang.org/grpcdependency, ensuring compatibility with new health check functionality. [1] [2] [3]Documentation