Skip to content

Conversation

nepomucen
Copy link

What does this change resolves ?

  • it backports fix from fbreckle/go-netbox to enable support for Netbox 4.x:
  • fixes the following error in go-netbox REST API call to dcim_devices_retrieve resource in Netbox
  • tested with Netbox v4.1.11 version

Error: json: cannot unmarshal object into Go struct field NestedIPAddress.results.primary_ip.family of type int64

@auto-assign auto-assign bot requested a review from smutel January 23, 2025 14:38
@smutel
Copy link
Owner

smutel commented Jan 24, 2025

Hello,

Thank you for your PR. Unfortunately I will not continue to maintain this repo.

For the story:

I don't how you use this lib but if you can try go-netbox-community and tell me if you encounter issues, it will be great ...

@nepomucen
Copy link
Author

Hello, thank you @smutel for your reply.

To be honest, I'm not a Go expert, and I already failed the very first step to test run your new provider version from UpdateForNetbox4 branch - it failed to build. I spent some time troubleshooting it, but wasn't able to fix it, and I gave up eventually.

Just a side comment. I noticed also that the same API calls to Netbox through json data source very often end up now in "context: deadline exceeded" error (always at 30 sec), since I upgraded my Netbox installation to v4.1.11 version. Bit weird, and suggests me rather a performance degradation of the new Netbox version with comparison to 3.4 baseline. Terraform docs warns about such a possibility here.

I studied your provider's source code a bit, and it looks like the timeout error I hit, correlates with fixed one in go-openapi/runtime/client package.

@smutel
Copy link
Owner

smutel commented Apr 30, 2025

Replace by #63

@smutel smutel closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants