Skip to content

Conversation

Lunarnovaa
Copy link
Collaborator

Quick PR to move .gtkrc-2.0 to a more sane (XDG compliant) location.

Meta

AI used to generate code included in this PR?: No

All Submissions:

  • Formatted commit message in accordance with CONTRIBUTING.md guidelines
  • Filled in all meta items
  • Mentioned any blockers before the PR can merge
  • Verified there are no conflicting PRs open

@nezia1
Copy link
Collaborator

nezia1 commented Jul 30, 2025

Hey, there's a small issue with this: with the way environment variables on Hjem are handled, it's not guaranteed that GTK2_RC_FILES will be sourced (but this is a design thing that I'm not sure we can solve upstream), as either a script needs to be sourced by the module or the environment variables need to be mapped. I wouldn't make this the default, perhaps we can make this a boolean option instead?

@Lunarnovaa
Copy link
Collaborator Author

That's a good point, I agree.

@Lunarnovaa
Copy link
Collaborator Author

Hey, there's a small issue with this: with the way environment variables on Hjem are handled, it's not guaranteed that GTK2_RC_FILES will be sourced (but this is a design thing that I'm not sure we can solve upstream), as either a script needs to be sourced by the module or the environment variables need to be mapped. I wouldn't make this the default, perhaps we can make this a boolean option instead?

@nezia1 done

nezia1
nezia1 previously approved these changes Aug 7, 2025
Copy link
Collaborator

@nezia1 nezia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nezia1 nezia1 merged commit 1ed95e0 into main Oct 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants