Skip to content

Conversation

@Lunarnovaa
Copy link
Collaborator

@Lunarnovaa Lunarnovaa commented Jun 11, 2025

General PR to address some current issues of the docs. Namely:

  • Improve general cohesion of documentation
  • Add documentation to our docs page
  • Fix the custom link (CNAME)
  • See if I can mess with CSS to add syntax highlighting and maybe change up the color scheme to be more individual to HJR
  • Clean up the docs more generally, unify tone and such
  • Break up CONTRIBUTING.md into multiple smaller files that link together (and modify the sidebar to make this cleaner)
  • Add a simple index.md landing page

Current Blockers:

  • New SNUG website domain
  • NDG additive stylesheet option

Meta

Related Issue: #73

AI used to generate code included in this PR?: No

All Submissions:

  • Formatted commit message in accordance with CONTRIBUTING.md guidelines
  • Filled in all meta items
  • Mentioned any blockers before the PR can merge
  • Verified there are no conflicting PRs open

@Lunarnovaa
Copy link
Collaborator Author

The stylesheet additions will be in another PR so that we can get the CNAME and docs structure changes mergedb.

@Lunarnovaa Lunarnovaa marked this pull request as ready for review June 18, 2025 16:11
@Lunarnovaa Lunarnovaa requested a review from nezia1 June 18, 2025 16:11
@a-usr
Copy link
Member

a-usr commented Jun 18, 2025

Imo CNAME should be put in its own file under the docs dir for easy visibility, just like what I did. If you change that I'd be happy to close my own pr (unless you already did)

@Lunarnovaa
Copy link
Collaborator Author

Imo CNAME should be put in its own file under the docs dir for easy visibility, just like what I did. If you change that I'd be happy to close my own pr (unless you already did)

I'm not sure how it helps readability, especially since it just adds another file in the directory for a single line of text

@nezia1 nezia1 assigned nezia1 and Lunarnovaa and unassigned nezia1 Jun 18, 2025
nezia1
nezia1 previously approved these changes Jun 18, 2025
Copy link
Collaborator

@nezia1 nezia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work. LGTM, added a review comment but non blocking

@a-usr
Copy link
Member

a-usr commented Jun 18, 2025

I'm not sure how it helps readability, especially since it just adds another file in the directory for a single line of text

Not readability, visibility. The difference is, if anyone tries to change the domain in the future, for any reason, and runs into the issue that the CNAME gets changed each doc workflow run for no apparent reason, a file is way easier to find than a single line of text

@Lunarnovaa
Copy link
Collaborator Author

  • Moved CNAME to own file
  • Moved markdown files to docs/manual
  • Small cleanup/refactor

@Lunarnovaa
Copy link
Collaborator Author

Adding a couple more things.

@Lunarnovaa
Copy link
Collaborator Author

Addressed nezia's request and added a workflow to test build the docs. Please give feedback on the workflow, I'm pretty unfamiliar with them.

Copy link
Collaborator

@nezia1 nezia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last question, but LGTM otherwise. The section on defaultText is really good stuff :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we build docs already in the deployment workflow? The workflow would fail anyways if it was not able to be built, so I'm unsure if we really need this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That occurs on merge. This workflow is a test workflow. So it's the difference between building the docs when a PR is opened to make sure it doesn't break anything, and building the docs after the PR is merged when it's either gonna break it or not.

@Lunarnovaa
Copy link
Collaborator Author

  • Docs check workflow no longer runs if only tests were changed
  • Example test is now nushell, not ncmpcpp
  • Added link checking to the docs check workflow

@Lunarnovaa
Copy link
Collaborator Author

The 29 errors on the link checker workflow is a bug with ndg atm, should be fine on our actual docs.

- README no longer contains technical details on hjr
- docs index now separated into Installation and Quirks
- Environmental Variables section in Quirks
@nezia1
Copy link
Collaborator

nezia1 commented Jun 20, 2025

LGTM, but holding my review until ndg's bug is fixed

@Lunarnovaa
Copy link
Collaborator Author

LGTM, but holding my review until ndg's bug is fixed

I might just export the template and try to modify things myself.

@Lunarnovaa
Copy link
Collaborator Author

Lunarnovaa commented Jun 21, 2025

Alright, so the errors aren't a bug perse with ndg, rather, it's due to the javascript that adds anchors to headings not actually running at buildtime, even though it totally works fine on the published site. So, I've added anchors to the headings manually, and updated CONTRIBUTING to reflect that.

What's left I want to do:

  • See if I can mess with CSS to add syntax highlighting and maybe change up the color scheme to be more individual to HJR
  • Clean up the docs more generally, unify tone and such
  • Break up CONTRIBUTING.md into multiple smaller files that link together (and modify the sidebar to make this cleaner)
  • Add a simple index.md landing page

@Lunarnovaa
Copy link
Collaborator Author

Superseded by #115.

@Lunarnovaa Lunarnovaa closed this Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants