Modify missedPackets to include entry ID #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore messages contain actual entry ID to correct client offset
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the restoreSession method to append the Redis stream entry ID to each missed packet during connection state recovery. This ensures that clients receive the actual entry ID needed to correctly track their offset position in the event stream, addressing issues with offset synchronization during reconnection.
Key Changes:
- Clones packet data using
slice()before modification to avoid mutating the original data - Appends the Redis stream entry ID to each missed packet
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore messages contain actual entry ID to correct client offset
#39
socketio/socket.io#5419