fix: Color picker aligned with actual color in 'Smoky Triangle'#2342
Open
cieplypolar wants to merge 4 commits intomainfrom
Open
fix: Color picker aligned with actual color in 'Smoky Triangle'#2342cieplypolar wants to merge 4 commits intomainfrom
cieplypolar wants to merge 4 commits intomainfrom
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (349 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the “Smoky Triangle” example’s To Color control so the color picker’s displayed initial color matches the actual rendered color, despite the shader using HDR-ish toColor values (> 1) internally.
Changes:
- Introduces separate initial values for the uniform buffer (
initialToColorBuffer) vs. the UI color picker (initialToColorPicker). - Adds a special-case in
onColorChangeto write the HDR buffer value during initial control initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cieplypolar
changed the title
Collaborator
|
I think I would rather limit the color buffer value to a normalized vector, and multiply it in the shader. |
Collaborator
Author
I don't understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
