Fix Pressable
's onPress
being called on cancellation
#3678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still WIP - found a better way of fixing this issue, I'm still testing it
Description
This PR fixed the
Pressable
'sonPress
callback being called despite the press being cancelled.100% of the credit for finding and fixing this issue goes to @gigobyte.
Fixes #3609
Test plan
Pressable
to the right.onPress
callback would be called without the finger being lifted.onPress
is no longer called when the finger isn't lifted.