[Docs] Do not highlight wrong onBegin transition - #4361
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the callbacks-flow diagram example in the docs so it no longer highlights the onBegin → onFinalize transition when the gesture actually activated (i.e., when the correct finalize path is onDeactivate → onFinalize).
Changes:
- Removed an incorrect
begin_finalizeedge pulse from the “was active” finalize path, ensuring onlydeactivate_finalizeis highlighted after activation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that arrow leading towards
onFinalizefromonBegineven if handler activated. This PR fixes this issue.Before
Screen.Recording.2026-07-29.at.13.44.35.mov
After
Screen.Recording.2026-07-29.at.13.45.26.mov
Test plan
Play with example