Skip to content

Conversation

@JohannesHoffmann
Copy link
Contributor

@JohannesHoffmann JohannesHoffmann commented Mar 13, 2023

This solves the bugs in #55

What have i done:

  • added fit or not fit check in extra test on rotated node to check for its better choice
  • removes padding on fit comparisons

I have doubts with the padding issue and my solution. It rotates only the fourth why not all? Is my solution correct?

@JohannesHoffmann
Copy link
Contributor Author

JohannesHoffmann commented Mar 13, 2023

I have a questin right here. I struggled a lot to reproduce the bugs because in maxrects-packer.ts the option for square is false and in maxrects-bin.ts the same option is true. Was hard to find this out. Should this be the same default options?

@soimy soimy merged commit 94b2b04 into soimy:master Aug 27, 2025
1 of 5 checks passed
@soimy
Copy link
Owner

soimy commented Aug 27, 2025

Due to doc's default value, square shall be default to false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants