Skip rate limitter if no borrows #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osits, but are deposited in a reserve with bad oracles. In such case, we skip liveness checks. However, while calculating max outflow the math depended on a value that was set upon refresh. That caused the max outflow to be zero and blocked withdrawals.
vanitymnm
commented
May 14, 2025
vanitymnm
commented
May 14, 2025
vanitymnm
commented
May 14, 2025
| max_outflow_usd, | ||
| // min here bc this function can overflow if max_outflow_usd is u64::MAX | ||
| // the actual value doesn't matter too much as long as its sensible | ||
| obligation.deposited_value.try_mul(2)?, |
There was a problem hiding this comment.
or use a static value here that doesn't overflow
nope-finance
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #195
We want to support withdraws for users that only have borrows, no deposits, but are deposited in a reserve with bad oracles.
In such case, we skip liveness checks.
However, while calculating max outflow the math depended on a value that was set upon refresh. That caused the max outflow to be zero and blocked withdrawals.
This change is safe to introduce as the rate limiter is a client only limiter.
It can be avoided by instead using
withdraw+redeembecause in those casesaccount_for_rate_limiteris false.