Skip to content

upgrade: geolocation package upgrade for Solid 2.0#841

Open
davedbase wants to merge 4 commits intosolidjs-community:mainfrom
davedbase:update/v2/geolocation
Open

upgrade: geolocation package upgrade for Solid 2.0#841
davedbase wants to merge 4 commits intosolidjs-community:mainfrom
davedbase:update/v2/geolocation

Conversation

@davedbase
Copy link
Copy Markdown
Member

Proposal for upgrading to Solid 2.0 which includes:

  • Added makeGeolocation(options?) — non-reactive one-shot query returning [query, cleanup] tuple, no Solid owner required
  • Added makeGeolocationWatcher(options?) — non-reactive continuous watcher returning [store, cleanup] tuple, no Solid owner required
  • createGeolocation now returns [Accessor<GeolocationCoordinates>, refetch] — async memo that suspends with <Suspense>, re-queries when reactive options change or refetch() is called. Supports isPending() for background re-query indicators
  • createGeolocationWatcher now returns { location: Accessor<GeolocationCoordinates>, error: Accessor<GeolocationPositionError | null> }location suspends until the first GPS fix then updates reactively; error is a signal for recoverable in-component error handling
  • Replaced createResource with async createMemo + version signal
  • Replaced createComputed with createEffect
  • Updated peer dependency to solid-js@^2.0.0

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

⚠️ No Changeset found

Latest commit: 91331aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant