Skip to content

fix: use same code path as Vite 6 for Vite 7 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

sapphi-red
Copy link
Contributor

The same code path for Vite 6 should be used for Vite 7+.

refs vitejs/vite#20231

Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 824328d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sapphi-red sapphi-red marked this pull request as ready for review June 18, 2025 02:07
@botanegg
Copy link

botanegg commented Jun 25, 2025

isVite6 becomes true for Vite 7+ after this patch

I suggest rename the variable to reflect its actual behavior - isVite6OrLater or (imo better) viteVersionAtLeast6

@AFatNiBBa
Copy link

This line should also be changed by adding version 7, this would fix #221

@brillout
Copy link

@ryansolid FYI this is blocking Vike users from updating to Vite 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants