Revert the deprecation of #redirect_back_or_default method
#4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deprecated `#redirect_back_or_default` method in solidusio#4533 [1]. However, the original plan was halted because of auth problems in solidus_auth_devise. See solidusio/solidus_auth_devise/232 [2] for details. [1] - solidusio#4533 [2] - solidusio/solidus_auth_devise#232
github-actions
bot
added
the
changelog:solidus_core
elia
approved these changes
Jan 16, 2023
2 tasks
kennyadsl
approved these changes
Jan 17, 2023
|
@waiting-for-dev not sure this should be labeled as a bug. It has never been released in a version. WDYT? |
You're right, but I'd see it as a "bug in master", if that makes sense. At least, that's definitely not a feature 🙂 I'm fine if you prefer to remove the label; I only applied that as we committed to adding one of those two labels to every PR, though. |
waiting-for-dev
deleted the
waiting-for-dev/revert_deprecation_of_redirect_back_or_default
branch
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We deprecated
#redirect_back_or_defaultmethod in #4533. However, the original plan was halted because of auth problems in solidus_auth_devise. See solidusio/solidus_auth_devise#232 for details.Ref. #4846
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the README to account for my changes.