Add Lockable option to Devise #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locking Admin users after consecutive failed attempts is a good practice to prevent Brute Force password detection. This adds the necessary backbone (controller, routes and email template) so that using the lockable strategy with the extension requires minimal work over it.
cesartalves
force-pushed
the
cesartalvez/add-lockable-option
branch
4 times, most recently
from
92b7e88 to
483a40c
Compare
cesartalves
force-pushed
the
cesartalvez/add-lockable-option
branch
from
483a40c to
33da025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locking Admin users after consecutive failed attempts is a good practice to prevent Brute Force password detection.
This adds the necessary backbone (controller, routes and email template) so that using the lockable strategy with the extension requires minimal work over it.
I added the
unlockablecontrollers only on the Admin side as I believe it's the most useful / pressing.Thankfully the migrations and translations were already included which made this change pretty slim!