Use new unauthorized redirect handler class endpoints #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Spree::Config#redirect_back_on_unauthorized` has been removed in Solidus 3.0, and we're on 4.4 now. This can all go. If users have followed the deprecation warnings, then they should be fine with using `redirect_back`. Note that we're not using redirect_back in the admin, as logging out redirects to the admin root controller, which in turn redirects back, leading to an infinite redirect. Infinite redirects are no good.
We have to lambdas, so we need two classes.
This makes the `prepare_{frontend,backend}` methods which instantiate
the base controller and the admin base controller, requiring all of
ActionController::Base, unnecessary to call for newer Solidus versions.
Depends on solidusio/solidus#6051
mamhoff
force-pushed
the
use-new-unauthorized-redirect-handler-class-endpoint
branch
from
942e1c1 to
79f443c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR drops support for the old configuration option
Spree::Config.redirect_back_on_unauthorizedand extracts the redirect handling into classes, which can then be fed into the new extension points from solidusio/solidus#6051.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: