Use the NRBC type 2 with $\lambda=0$ #1 #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
reviewed
May 31, 2024
| .def_timed("march_half_so0", &wrapped_type::march_half_so0, py::arg("odd_plane")) | ||
| .def_timed("treat_boundary_so0", &wrapped_type::treat_boundary_so0) | ||
| .def_timed("treat_boundary_so1", &wrapped_type::treat_boundary_so1) | ||
| .def_timed("march_half_so0", &wrapped_type::march_half_so0, py::arg("odd_plane")) |
There was a problem hiding this comment.
This is not a refactoring PR. It is unnecessary to change the order of existing code. Next time please avoid doing it in a non-refactoring PR.
| { | ||
| march_half_so0(false); | ||
| treat_boundary_so0(); | ||
| treat_boundary_so1(); |
There was a problem hiding this comment.
Why changing the unused solver?
| { | ||
| march_half_so0(false); | ||
| treat_boundary_so0(); | ||
| treat_boundary_so1(); |
There was a problem hiding this comment.
Ditto (Why changing the unused solver?)
| { | ||
| namespace py = pybind11; | ||
|
|
||
There was a problem hiding this comment.
Beware of trailing white spaces (TWS). Never add TWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue #330
This PR includes:
Obviously, the result shows that there must be something wrong in the code.
