Skip to content

Refactor: comment for MODMESH_PYSIDE6_FULL macro #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: comment for MODMESH_PYSIDE6_FULL macro #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/modmesh/pilot/wrap_pilot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include <QClipboard>
#include <QMenu>

// Usually MODMESH_PYSIDE6_FULL is not defined unless for debugging.
// PySide6 is required since 2023 (see issue https://github.com/solvcon/modmesh/issues/220)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old comment should be kept. It should read like:

// PySide6 is required since 2023 (see issue https://github.com/solvcon/modmesh/issues/220)
// Usually MODMESH_PYSIDE6_FULL is not defined unless for debugging.

#ifdef MODMESH_PYSIDE6_FULL
#include <pyside.h>
#else // MODMESH_PYSIDE6_FULL
Expand Down
Loading