[202505][Mellanox] Integrate HW-MGMT Version 7.0040.4034 #513
Conversation
## Patch List * 8013-hwmon-pmbus-mp2975-Clear-interrupts-at-probe.patch : * 8014-platform-mellanox-mlxreg-dpu-Debug-trace-for-dpu-pro.patch :
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
Integrates two new Mellanox HW management patches: one adds debug trace messages to mlxreg-dpu probe path, and another clears mp2975 PMBus faults during probe to avoid spurious ALARM conditions.
- Adds 8013 patch to clear mp2975 faults (labeled as interrupts) at probe.
- Adds 8014 patch to introduce probe-time logging for mlxreg-dpu.
- Updates patch/series to include the new patch entries.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| patch/series | Registers the two new Mellanox HW-MGMT patches in build sequence. |
| patch/8014-platform-mellanox-mlxreg-dpu-Debug-trace-for-dpu-pro.patch | Adds probe-time informational logs and deferred probe trace in mlxreg-dpu.c. |
| patch/8013-hwmon-pmbus-mp2975-Clear-interrupts-at-probe.patch | Introduces function to clear PMBus fault registers during mp2975 device probe. |
Comments suppressed due to low confidence (1)
patch/8014-platform-mellanox-mlxreg-dpu-Debug-trace-for-dpu-pro.patch:1
- [nitpick] Using dev_info for routine probe and deferred retry messages can produce noisy kernel logs; since the patch subject calls this a "Debug trace", dev_dbg would be more appropriate (e.g. dev_dbg(&pdev->dev, ...)) to allow conditional visibility under dynamic debug.
From e7838edd2acc793f3b43ab04b3693a340273c330 Mon Sep 17 00:00:00 2001
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| From 8d8f4d52f5655747df20317ceaf628e29070475e Mon Sep 17 00:00:00 2001 | ||
| From: Ciju Rajan K <[email protected]> | ||
| Date: Tue, 9 Sep 2025 08:48:47 +0300 | ||
| Subject: hwmon: pmbus: mp2975: Clear interrupts at probe |
There was a problem hiding this comment.
Both the patch subject and the in-code comment refer to "interrupts" while the implementation clears fault registers (CLEAR_FAULTS and CLEAR_CAT_FAULTS); adjust wording to "Clear faults at probe" to accurately reflect behavior.
| if (ret) | ||
| return ret; | ||
|
|
||
| + /* Clear interrupts. */ |
There was a problem hiding this comment.
Both the patch subject and the in-code comment refer to "interrupts" while the implementation clears fault registers (CLEAR_FAULTS and CLEAR_CAT_FAULTS); adjust wording to "Clear faults at probe" to accurately reflect behavior.
3 participants
Why I did it
Integrate HW-MGMT 7.0040.4034 Changes
Patch List
How I did it
Run make integrate-mlnx-hw-mgmt