[202405] Stop the config_manager child process on exception in chassisd - #763
Closed
kenneth-arista wants to merge 1 commit into
Closed
kenneth-arista wants to merge 1 commit into
kenneth-arista wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…onic-net#727) Context is in: sonic-net/sonic-buildimage#24775 TLDR: chassisd process doesn't die when a crash occurs because the config_manager child process is still running. Adding try/finally to cleanup the config_manager properly when a crash occurs to let chassisd die and restart. Confirmed that if I add an assert False after config_manager is created I see the chassisd process die and restart as expected (previously the process would live on). Note: When reviewing the diff select hide whitespaces to make the diff easier to read. Signed-off-by: Kenneth Cheung <kennethcheung@arista.com>
kenneth-arista
force-pushed
the
202405-chassisd-crash-fix
branch
from
February 26, 2026 00:39
f3f516e to
fbed8b7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Feb 26, 2026
Contributor
|
@bmridul @judyjoseph @arlakshm for viz. |
arlakshm
approved these changes
Feb 26, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@kenneth-arista could you rebase your branch ? we have pushed a commit to fix this PR buid issue |
Author
|
Merged equivalent cherry-pick to Azure/sonic-platform-daemons.msft#62 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #727
Context is in: sonic-net/sonic-buildimage#24775
TLDR:
chassisdprocess doesn't die when a crash occurs because theconfig_managerchild process is still running. Addingtry/finallyto cleanup theconfig_managerproperly when a crash occurs to letchassisddie and restart.Confirmed that if I add an
assert Falseafterconfig_manageris created I see thechassisdprocess die and restart as expected (previously the process would live on).Note: When reviewing the diff select
hide whitespacesto make the diff easier to read.