Restart GNMI and Telemetry on VRF update through GCU - #4395
Merged
bhouse-nexthop merged 1 commit intoJun 15, 2026
Merged
bhouse-nexthop merged 1 commit into
bhouse-nexthop merged 1 commit into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
March 26, 2026 00:16
fadae12 to
c5c60ae
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
April 16, 2026 00:03
c5c60ae to
1d3be98
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@DavidZagury @qiluo-msft @wen587 can you review as you have reviewed/edited code in this area, we are targeting 202605 so would like to get this reviewed asap as it has gone stale, thanks |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
April 29, 2026 23:27
1d3be98 to
2fd6d03
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@sneelam20 do you have reviewers in mind you could assign this to, this feature is targeting 202605 which is branching soon. |
Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
May 25, 2026 17:19
2fd6d03 to
b547ce4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sneelam20
approved these changes
May 28, 2026
kwangsuk
approved these changes
Jun 11, 2026
anders-nexthop
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jun 23, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener Summary: Fixes sonic-net/sonic-gnmi#504 Depends on: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-utilities#4395 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867 #### How did you do it? Parameterized `test_gnmi_configdb.py` with `default`, `mgmt_vrf` and a custom VRF scenario. #### How did you verify/test it? Manual verification of relevant changes are already done with the `sonic-buildimage` changes. The updated tests ran successfully in local setup. #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? Any testbed works for the default and `mvrf` test cases. Custom non-mgmt VRF testcase requires a `t0` topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> NA #### A picture of a cute animal (not mandatory but encouraged)  Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 25, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener Summary: Fixes sonic-net/sonic-gnmi#504 Depends on: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-utilities#4395 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867 #### How did you do it? Parameterized `test_gnmi_configdb.py` with `default`, `mgmt_vrf` and a custom VRF scenario. #### How did you verify/test it? Manual verification of relevant changes are already done with the `sonic-buildimage` changes. The updated tests ran successfully in local setup. #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? Any testbed works for the default and `mvrf` test cases. Custom non-mgmt VRF testcase requires a `t0` topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> NA #### A picture of a cute animal (not mandatory but encouraged)  Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
Yogapriya-cisco
pushed a commit
to vrajeshe/sonic-utilities
that referenced
this pull request
Jul 10, 2026
#### What I did Restarting gNMI and Telemetry services if the VRF is changed via GCU. Fixes: sonic-net/sonic-gnmi#504 Related PRs: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-mgmt#20456 #### How I did it This change adds gnmi and telemetry validators to check for a change in VRF and restarts the services accordingly. #### How to verify it Added gNMI and Telemetry service validator tests have been passing. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed) Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai> Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jul 16, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener Summary: Fixes sonic-net/sonic-gnmi#504 Depends on: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-utilities#4395 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867 #### How did you do it? Parameterized `test_gnmi_configdb.py` with `default`, `mgmt_vrf` and a custom VRF scenario. #### How did you verify/test it? Manual verification of relevant changes are already done with the `sonic-buildimage` changes. The updated tests ran successfully in local setup. #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? Any testbed works for the default and `mvrf` test cases. Custom non-mgmt VRF testcase requires a `t0` topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> NA #### A picture of a cute animal (not mandatory but encouraged)  Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
ssithaia-ebay
pushed a commit
to ssithaia-ebay/sflow-yang-sonic-mgmt
that referenced
this pull request
Jul 21, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener Summary: Fixes sonic-net/sonic-gnmi#504 Depends on: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-utilities#4395 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867 #### How did you do it? Parameterized `test_gnmi_configdb.py` with `default`, `mgmt_vrf` and a custom VRF scenario. #### How did you verify/test it? Manual verification of relevant changes are already done with the `sonic-buildimage` changes. The updated tests ran successfully in local setup. #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? Any testbed works for the default and `mvrf` test cases. Custom non-mgmt VRF testcase requires a `t0` topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> NA #### A picture of a cute animal (not mandatory but encouraged)  Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai> Signed-off-by: ssithaia-ebay <ssithaian@ebay.com>
rameshraghupathy
pushed a commit
to rameshraghupathy/sonic-utilities
that referenced
this pull request
Jul 29, 2026
#### What I did Restarting gNMI and Telemetry services if the VRF is changed via GCU. Fixes: sonic-net/sonic-gnmi#504 Related PRs: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-mgmt#20456 #### How I did it This change adds gnmi and telemetry validators to check for a change in VRF and restarts the services accordingly. #### How to verify it Added gNMI and Telemetry service validator tests have been passing. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed) Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai> Signed-off-by: Ramesh Raghupathy <ram@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Aug 24, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener Summary: Fixes sonic-net/sonic-gnmi#504 Depends on: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-utilities#4395 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867 #### How did you do it? Parameterized `test_gnmi_configdb.py` with `default`, `mgmt_vrf` and a custom VRF scenario. #### How did you verify/test it? Manual verification of relevant changes are already done with the `sonic-buildimage` changes. The updated tests ran successfully in local setup. #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? Any testbed works for the default and `mvrf` test cases. Custom non-mgmt VRF testcase requires a `t0` topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> NA #### A picture of a cute animal (not mandatory but encouraged)  Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Restarting gNMI and Telemetry services if the VRF is changed via GCU.
Fixes: sonic-net/sonic-gnmi#504
Related PRs:
How I did it
This change adds gnmi and telemetry validators to check for a change in VRF and restarts the services accordingly.
How to verify it
Added gNMI and Telemetry service validator tests have been passing.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)