Skip to content

Fix handleTouchEnd called not after a handleTouchStart #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix handleTouchEnd called not after a handleTouchStart #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac96090
fix handleTouchEnd that is called sometimes without first a handleTou…
serut Apr 18, 2018
1d2c443
Add the build command inside the package.json
serut Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"description": "ScrollArea component for react",
"main": "./dist/scrollArea.js",
"scripts": {
"test": "./node_modules/.bin/karma start karma.config.js --single-run --browsers PhantomJS"
"test": "./node_modules/.bin/karma start karma.config.js --single-run --browsers PhantomJS",
"build": "gulp build"
},
"repository": {
"type": "git",
Expand Down
10 changes: 9 additions & 1 deletion src/js/ScrollArea.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,17 @@ export default class ScrollArea extends React.Component {
}

handleTouchEnd(e) {
let {deltaX, deltaY, timestamp} = this.eventPreviousValues;
let deltaX,
deltaY,
timestamp;
if (this.eventPreviousValues) {
deltaX = this.eventPreviousValues.deltaX;
deltaY = this.eventPreviousValues.deltaY;
timestamp = this.eventPreviousValues.timestamp;
}
if (typeof deltaX === 'undefined') deltaX = 0;
if (typeof deltaY === 'undefined') deltaY = 0;
if (typeof timestamp === 'undefined') timestamp = Date.now();
if (Date.now() - timestamp < 200) {
this.setStateFromEvent(this.composeNewState(-deltaX * 10, -deltaY * 10), eventTypes.touchEnd);
}
Expand Down