-
Notifications
You must be signed in to change notification settings - Fork 174
feat(auth): github app #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fa8e0d2
properly handle emails for github app auth case
msukkari b96a35a
add docs info for auth through github app
msukkari d69851c
more info in docs for user auth perms
msukkari 1360caa
modify review agent env var names
msukkari 1cd9007
github app service auth
msukkari 4af3b53
coderabbit suggestions
msukkari b0dc257
merge main
msukkari 2d2d540
fixes
msukkari 49f1f05
fix build
msukkari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| {/* THIS IS A AUTO-GENERATED FILE. DO NOT MODIFY MANUALLY! */} | ||
| ```json | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "title": "AppConfig", | ||
| "oneOf": [ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "type": "object", | ||
| "title": "GithubAppConfig", | ||
| "properties": { | ||
| "type": { | ||
| "const": "githubApp", | ||
| "description": "GitHub App Configuration" | ||
| }, | ||
| "deploymentHostname": { | ||
| "type": "string", | ||
| "format": "url", | ||
| "default": "github.com", | ||
| "description": "The hostname of the GitHub App deployment.", | ||
| "examples": [ | ||
| "github.com", | ||
| "github.example.com" | ||
| ], | ||
| "pattern": "^[^\\s/$.?#].[^\\s]*$" | ||
| }, | ||
| "id": { | ||
| "type": "string", | ||
| "description": "The ID of the GitHub App." | ||
| }, | ||
| "privateKey": { | ||
| "description": "The private key of the GitHub App.", | ||
| "anyOf": [ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "secret": { | ||
| "type": "string", | ||
| "description": "The name of the secret that contains the token." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "secret" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "env": { | ||
| "type": "string", | ||
| "description": "The name of the environment variable that contains the token. Only supported in declarative connection configs." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "env" | ||
| ], | ||
| "additionalProperties": false | ||
| } | ||
| ] | ||
| }, | ||
| "privateKeyPath": { | ||
| "description": "The path to the private key of the GitHub App.", | ||
| "anyOf": [ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "secret": { | ||
| "type": "string", | ||
| "description": "The name of the secret that contains the token." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "secret" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "env": { | ||
| "type": "string", | ||
| "description": "The name of the environment variable that contains the token. Only supported in declarative connection configs." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "env" | ||
| ], | ||
| "additionalProperties": false | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type", | ||
| "id" | ||
| ], | ||
| "oneOf": [ | ||
| { | ||
| "required": [ | ||
| "privateKey" | ||
| ] | ||
| }, | ||
| { | ||
| "required": [ | ||
| "privateKeyPath" | ||
| ] | ||
| } | ||
| ], | ||
| "additionalProperties": false | ||
| } | ||
| ] | ||
| } | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| {/* THIS IS A AUTO-GENERATED FILE. DO NOT MODIFY MANUALLY! */} | ||
| ```json | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "type": "object", | ||
| "title": "GithubAppConfig", | ||
| "properties": { | ||
| "type": { | ||
| "const": "githubApp", | ||
| "description": "GitHub App Configuration" | ||
| }, | ||
| "deploymentHostname": { | ||
| "type": "string", | ||
| "format": "url", | ||
| "default": "github.com", | ||
| "description": "The hostname of the GitHub App deployment.", | ||
| "examples": [ | ||
| "github.com", | ||
| "github.example.com" | ||
| ], | ||
| "pattern": "^[^\\s/$.?#].[^\\s]*$" | ||
| }, | ||
| "id": { | ||
| "type": "string", | ||
| "description": "The ID of the GitHub App." | ||
| }, | ||
| "privateKey": { | ||
| "description": "The private key of the GitHub App.", | ||
| "anyOf": [ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "secret": { | ||
| "type": "string", | ||
| "description": "The name of the secret that contains the token." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "secret" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "env": { | ||
| "type": "string", | ||
| "description": "The name of the environment variable that contains the token. Only supported in declarative connection configs." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "env" | ||
| ], | ||
| "additionalProperties": false | ||
| } | ||
| ] | ||
| }, | ||
| "privateKeyPath": { | ||
| "description": "The path to the private key of the GitHub App.", | ||
| "anyOf": [ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "secret": { | ||
| "type": "string", | ||
| "description": "The name of the secret that contains the token." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "secret" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "env": { | ||
| "type": "string", | ||
| "description": "The name of the environment variable that contains the token. Only supported in declarative connection configs." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "env" | ||
| ], | ||
| "additionalProperties": false | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "required": [ | ||
| "type", | ||
| "id" | ||
| ], | ||
| "oneOf": [ | ||
| { | ||
| "required": [ | ||
| "privateKey" | ||
| ] | ||
| }, | ||
| { | ||
| "required": [ | ||
| "privateKeyPath" | ||
| ] | ||
| } | ||
| ], | ||
| "additionalProperties": false | ||
| } | ||
| ``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.