Skip to content

chore(tech-debt): Remove built-in secret manager #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

chore(tech-debt): Remove built-in secret manager #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6dbe07
remove built-in secret manager
msukkari Oct 31, 2025
43662bc
changelog
msukkari Oct 31, 2025
f49df78
merge main
msukkari Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed "The account is already associated with another user" errors with GitLab oauth provider. [#584](https://github.com/sourcebot-dev/sourcebot/pull/584)
- Fixed error when viewing a generic git connection in `/settings/connections`. [#588](https://github.com/sourcebot-dev/sourcebot/pull/588)

## Removed
- Removed built-in secret manager. [#592](https://github.com/sourcebot-dev/sourcebot/pull/592)

## [4.8.1] - 2025-10-29

### Fixed
Expand Down
24 changes: 1 addition & 23 deletions docs/docs/connections/ado-cloud.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ If you're not familiar with Sourcebot [connections](/docs/connections/overview),
Azure Devops Cloud requires you to provide a PAT in order to index your repositories. To learn how to create PAT, check out the [Azure Devops docs](https://learn.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=Windows).
Sourcebot needs the `Read` access for the `Code` scope in order to find and clone your repos.

Next, provide the access token via the `token` property, either as an environment variable or a secret:
Next, provide the access token via an environment variable which is referenced in the `token` property:

<Tabs>
<Tab title="Environment Variable">
Expand All @@ -113,28 +113,6 @@ Next, provide the access token via the `token` property, either as an environmen
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your PAT:

![](/images/secrets_list.png)

2. Add the `token` property to your connection config:

```json
{
"type": "azuredevops",
"deploymentType": "cloud",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>

## Schema reference
Expand Down
24 changes: 1 addition & 23 deletions docs/docs/connections/ado-server.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ If you're not familiar with Sourcebot [connections](/docs/connections/overview),
Azure Devops Server requires you to provide a PAT in order to index your repositories. To learn how to create PAT, check out the [Azure Devops docs](https://learn.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=Windows).
Sourcebot needs the `Read` access for the `Code` scope in order to find and clone your repos.

Next, provide the access token via the `token` property, either as an environment variable or a secret:
Next, provide the access token via an environment variable which is referenced in the `token` property:

<Tabs>
<Tab title="Environment Variable">
Expand All @@ -127,28 +127,6 @@ Next, provide the access token via the `token` property, either as an environmen
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your PAT:

![](/images/secrets_list.png)

2. Add the `token` property to your connection config:

```json
{
"type": "azuredevops",
"deploymentType": "server",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>

## Schema reference
Expand Down
23 changes: 1 addition & 22 deletions docs/docs/connections/gitea.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ In order to index private repositories, you'll need to generate a Gitea access t

![Gitea Access token creation](/images/gitea_pat_creation.png)

Next, provide the access token via the `token` property, either as an environment variable or a secret:
Next, provide the access token via an environment variable which is referenced in the `token` property:

<Tabs>
<Tab title="Environment Variable">
Expand All @@ -107,27 +107,6 @@ Next, provide the access token via the `token` property, either as an environmen
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your PAT:

![](/images/secrets_list.png)

2. Add the `token` property to your connection config:

```json
{
"type": "gitea",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>

## Connecting to a custom Gitea
Expand Down
23 changes: 1 addition & 22 deletions docs/docs/connections/github.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ In order to index private repositories, you'll need to generate a access token a
</Accordion>
</AccordionGroup>

Next, provide the access token via the `token` property, either as an environment variable or a secret:
Next, provide the access token via an environment variable which is referenced in the `token` property:

<Tabs>
<Tab title="Environment Variable">
Expand All @@ -154,27 +154,6 @@ Next, provide the access token via the `token` property, either as an environmen
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your PAT:

![](/images/secrets_list.png)

2. Add the `token` property to your connection config:

```json
{
"type": "github",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>

## Connecting to a custom GitHub host
Expand Down
23 changes: 1 addition & 22 deletions docs/docs/connections/gitlab.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ In order to index private projects, you'll need to generate a GitLab Personal Ac

![GitLab PAT Scope](/images/gitlab_pat_scopes.png)

Next, provide the PAT via the `token` property, either as an environment variable or a secret:
Next, provide the PAT via an environment variable which is referenced in the `token` property:

<Tabs>
<Tab title="Environment Variable">
Expand All @@ -142,27 +142,6 @@ Next, provide the PAT via the `token` property, either as an environment variabl
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your PAT:

![](/images/secrets_list.png)

2. Add the `token` property to your connection config:

```json
{
"type": "gitlab",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>

## Connecting to a custom GitLab host
Expand Down
23 changes: 0 additions & 23 deletions docs/snippets/bitbucket-app-password.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,4 @@
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your access token:

![](/images/secrets_list.png)

2. Add the `token` and `user` (username associated with the app password you created) properties to your connection config:

```json
{
"type": "bitbucket",
"deploymentType": "cloud",
"user": "myusername",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>
21 changes: 0 additions & 21 deletions docs/snippets/bitbucket-token.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,4 @@
ghcr.io/sourcebot-dev/sourcebot:latest
```
</Tab>

<Tab title="Secret">
<Note>Secrets are only supported when [authentication](/docs/configuration/auth/overview) is enabled.</Note>

1. Navigate to **Secrets** in settings and create a new secret with your PAT:

![](/images/secrets_list.png)

2. Add the `token` property to your connection config:

```json
{
"type": "bitbucket",
"token": {
"secret": "mysecret"
}
// .. rest of config ..
}
```

</Tab>
</Tabs>
9 changes: 0 additions & 9 deletions docs/snippets/schemas/v2/index.schema.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"token": {
"description": "A Personal Access Token (PAT).",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -274,7 +273,6 @@
"token": {
"description": "An authentication token.",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -465,7 +463,6 @@
"token": {
"description": "An access token.",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -779,7 +776,6 @@
"token": {
"description": "A Personal Access Token (PAT).",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -976,7 +972,6 @@
"token": {
"description": "An authentication token.",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -1167,7 +1162,6 @@
"token": {
"description": "An access token.",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -1563,7 +1557,6 @@
"token": {
"description": "A Personal Access Token (PAT).",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -1760,7 +1753,6 @@
"token": {
"description": "An authentication token.",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down Expand Up @@ -1951,7 +1943,6 @@
"token": {
"description": "An access token.",
"examples": [
"secret-token",
{
"env": "ENV_VAR_CONTAINING_TOKEN"
}
Expand Down
26 changes: 0 additions & 26 deletions docs/snippets/schemas/v3/app.schema.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,6 @@
"privateKey": {
"description": "The private key of the GitHub App.",
"anyOf": [
{
"type": "object",
"properties": {
"secret": {
"type": "string",
"description": "The name of the secret that contains the token."
}
},
"required": [
"secret"
],
"additionalProperties": false
},
{
"type": "object",
"properties": {
Expand Down Expand Up @@ -90,19 +77,6 @@
"privateKey": {
"description": "The private key of the GitHub App.",
"anyOf": [
{
"type": "object",
"properties": {
"secret": {
"type": "string",
"description": "The name of the secret that contains the token."
}
},
"required": [
"secret"
],
"additionalProperties": false
},
{
"type": "object",
"properties": {
Expand Down
18 changes: 0 additions & 18 deletions docs/snippets/schemas/v3/azuredevops.schema.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,7 @@
},
"token": {
"description": "A Personal Access Token (PAT).",
"examples": [
{
"secret": "SECRET_KEY"
}
],
"anyOf": [
{
"type": "object",
"properties": {
"secret": {
"type": "string",
"description": "The name of the secret that contains the token."
}
},
"required": [
"secret"
],
"additionalProperties": false
},
{
"type": "object",
"properties": {
Expand Down
Loading
Loading