This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Svelte]: Improve result indicator layout#62338
Draft
vovakulikov wants to merge 2 commits intomainfrom
Draft
Conversation
Member
|
Looks like this will conflict with https://github.com/sourcegraph/sourcegraph/pull/62317. Thoughts on how we should handle that? |
Contributor
Author
|
So after the pairing session, we agreed that this PR won't go to the May release, instead, we're going to merge https://github.com/sourcegraph/sourcegraph/pull/62317 and in this PR we split the result button into two buttons, info one with result count and reasons badge and action button which populates the query with additional filter to resolve the problem that info button shows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main intention to change here is to save vertical space, we already have a few panels and sticky headers in the search result block, and having an additional row in the sticky header above make this panel crowded especially on mid-size screens
Test plan