This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(frontend): remove metric for unavailable feature flags#64099
Open
stefanhengl wants to merge 2 commits intomainfrom
Open
chore(frontend): remove metric for unavailable feature flags#64099stefanhengl wants to merge 2 commits intomainfrom
stefanhengl wants to merge 2 commits intomainfrom
Conversation
I believe the metric and log was meant to be temporary. I noticed that my logs were full of "search feature flags are not available" while running a search job locally. I used the oportunity to clean up the code a little bit. Test plan: CI
github-actions
bot
added
team/product-platform
team/search-platform
Member
|
Doesn't that just mean we are not setting up feature flags properly for search jobs? IE we should add the relevant thing to ensure feature flags are set? |
Contributor
+1, and ideally feature flags would always be specified (even if they're just empty by default for tests). We could even keep this check, but upgrade it to an error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the metric and log was meant to be temporary and I don't see much use for them in practice. I noticed that my logs were full of "search feature flags are not available" while running a search job locally.
I used the oportunity to clean up the code a little bit.
Test plan:
CI