chore: Change from net to go-p2p #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
area/p2p
fredcarle
force-pushed
the
fredcarle/chore/use-go-p2p
branch
from
e8368fc to
6c3acaa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4051 +/- ##
===========================================
+ Coverage 74.21% 74.46% +0.24%
===========================================
Files 489 488 -1
Lines 45491 45230 -261
===========================================
- Hits 33761 33677 -84
+ Misses 9445 9298 -147
+ Partials 2285 2255 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
AndrewSisley
approved these changes
Oct 4, 2025
| Example: Connect to a peer | ||
| defradb client p2p connect /ip4/0.0.0.0/tcp/9171/p2p/12D3KooW... | ||
| Example: Connect to multiple peers |
There was a problem hiding this comment.
praise: Thanks for adding this
fredcarle
force-pushed
the
fredcarle/chore/use-go-p2p
branch
from
6c3acaa to
c43dbf3
Compare
AndrewSisley
reviewed
Oct 5, 2025
AndrewSisley
reviewed
Oct 5, 2025
| tracer = telemetry.NewTracer() | ||
| ) | ||
|
|
||
| type ( |
There was a problem hiding this comment.
thought: I had no idea we could do this, although it makes sense from a syntax perspective :) Thanks :)
fredcarle
force-pushed
the
fredcarle/chore/use-go-p2p
branch
from
c43dbf3 to
8fd3222
Compare
shahzadlone
reviewed
Oct 8, 2025
shahzadlone
reviewed
Oct 8, 2025
| storedRep.CollectionIDs = append(storedRep.CollectionIDs, col.CollectionID()) | ||
| // Update the list of collections for each replicator prior to persisting. | ||
| storedRepCollectionIDs := make(map[string]map[string]struct{}) // replicatorID => collectionID | ||
| addedCols := make(map[string][]client.Collection) // peerID => list of collections added |
There was a problem hiding this comment.
question: What does this comment mean? peerID => list of collections added
There was a problem hiding this comment.
it means its a map of peerIDs to the list of collections added.
fredcarle
force-pushed
the
fredcarle/chore/use-go-p2p
branch
from
9702b90 to
17e0b3b
Compare
fredcarle
force-pushed
the
fredcarle/chore/use-go-p2p
branch
from
17e0b3b to
d124e4d
Compare
fredcarle
force-pushed
the
fredcarle/chore/use-go-p2p
branch
from
96f57a8 to
75ebc11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #4048
Resolves #4031
Description
This PR removes the
defradb/netpackage in favour ofsourcenetwork/go-p2p. It brings in the latest changes fromgo-p2pwhich implies making changes to theclient.Hostinterface.Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: